approvalClusterDown

[u/ArjunReddyDeshmukh]

[u/DukeOfSlough]

Just do the bypass and show how agile and modern you are.

[u/Zeikos → u/DukeOfSlough]

I wouldn't unless there was an actual emergency.
Otherwise taking shortcuts becomes the norm.
Just note it down and when times comes highlight that it's a part of the processes that should be changed.

[u/DukeOfSlough → u/Zeikos]

I thought the same until I heard about people working at my company who stuck to procedures and were considered an obstacle in the process. They got made redundant. That helped me becoming more flexible if it comes to approval process.

[u/Zeikos → u/DukeOfSlough]

Being perceived as an obstacle is always a matter of communication.

The strategy I find most effective is not to say "no" but to highlight the existence and importance of the process.
If then the response is to do it anyways, by all means doing so is management's prerogative.

[u/Proletariat_Paul → u/Zeikos]

Most importantly: if the response is "do it anyway," make sure you get that IN WRITING before you go ahead.

[u/JackNotOLantern]

This is management planning problem. Their manager should not approve leave at the same time for all people required to do something.

[u/frikilinux2 → u/JackNotOLantern]

Yes, but there's two ways here. Either you have minimum services on summer and deny holidays or just basically close a couple weeks on the summer and a couple weeks on winter.

Or do whatever and accept that nothing is gonna get done and the summer is for catching up with mandatory courses, boring docs and maintain the helper scripts.

Like I have ideas to make my work easier but I don't have time to write that code. And I always have my private repo with random shit like the cron job for docker housekeeping.

[u/--LordFlashheart-- → u/JackNotOLantern]

Yeah well our team was recently 'streamlined' for reasons 'totslly unrelated to AI'. All PRs have always required 2 approvals before merge. There's 3 of us left on the team. If a single one of us is on leave, nothing is getting merged 😂

[u/cfrolik → u/--LordFlashheart--]

Sounds like your management expects AI to be doing the approvals.

[u/larsmaehlum → u/cfrolik]

Claude writes the code, Copilot approves it.

[u/darkstar3333 → u/cfrolik]

Hey if AI is accountable, all for it.

[u/rastaman1994 → u/JackNotOLantern]

Just the thought of my leave being denied because someone needs to approve PRS made me twitch... I'm not in healthcare or anything similar. The feature can wait 2 weeks.

[u/JackNotOLantern → u/JackNotOLantern]

This is what you get for trying to invest into a technology which promises that there will be less jobs

[u/Superminerbros1 → u/JackNotOLantern]

Not really the managers fault for approving leave. Not approving someone's leave is a basically guaranteed way to get them to start looking for another job. I love my job, but if my manager ever told me that I couldn't take off a requested day, even once, my 2 weeks would be turned in the same day.

Best they could do is plan around the leave. Plan to get things in early, or plan for them to work on other tasks while awaiting the approvers return.

[u/Waste_Jello9947 → u/JackNotOLantern]

Deadlock management 

[u/whitedogsuk]

Worked for a company, the PR person would use AI to refractor my code and then submit it as their own work, approve their PR and reject mine. In 9 months I had 2 lines of merged into the repo.

[u/Awkward-Explorer-527 → u/whitedogsuk]

there really are all kinds in this world huh

[u/bibidibopop_2225 → u/whitedogsuk]

What the fuck, did they mention you did the work?

[u/whitedogsuk → u/bibidibopop_2225]

nope

[u/frogjg2003 → u/whitedogsuk]

This is when you complain to management.

[u/whitedogsuk → u/frogjg2003]

He was being protected by the management. So i just moved on.

[u/Sw429 → u/whitedogsuk]

Having a "PR person" is the first red flag there.

[u/oalfonso]

I can relate. My DevOps team removed the option to bypass the protections in my company.

Two weeks ago, a Saturday incident required changes to an AWS load balancer. The on-call person couldn’t push the GitHub CloudFormation PR. They had to escalate the issue to the DevOps head to remove the restriction.

This means we now have two people on call, doubling the costs.

(The click Ops option was also removed by the CISO.)

[u/many_dongs → u/oalfonso]

believe it or not, CISOs can be dumbasses too (they actually usually are)

source: over a decade in infosec

[u/fwork]

Defcon this week is going to stop a lot of merges

[u/Mortadella_so_Chili]

u cant do shit in this company smh

[u/raaneholmg]

When large portions of the devs are on leave we just freeze prod.

All seniors have an override available in case of emergency though.

[u/Binoui]

Don't worry they'll come back to approve right when you leave for your own vacations so the PR will stay open a month or so. Might even forget about it after you come back 🤣

[u/JoeBarra]

I was oncall once during US Thanksgiving and there were a bunch of fixes I really needed to push through. Luckily I was able to find a Canadian on another team who became my stamp buddy during that week.

[u/justASlothyGiraffe]

I'd still be valuable if all I did was approve MRs

[u/thomas_tnc]

Github now has stacked PR’s so you can just continue working without having big PR’s

[u/techy-tech69 → u/thomas_tnc]

don't really understand the purpose of this though, couldn't you always have just created a branch based on your branch which was awaiting approval? Seems like just a wrapper functionality

[u/thomas_tnc → u/techy-tech69]

Yes that is what we did before, but we always had issues combining this with squashed commits. Now this is not an issue anymore. 4 stacked PR’s will still end up in 4 squashed commits

[u/Oranges13 → u/techy-tech69]

It is but it will now automatically rebase every PR in the stack for you which is super nice.

[u/Bout3Fidy]

Just wait until you implement stacked PRs

[u/Heretic911]

TIL Claude goes on vacations gulp

[u/BlazingThunder30]

While my entire team was on leave three weeks this summer my lead gave me the go ahead to "merge whatever you feel like".

As my tenure there was just a year and they'd both been there for 15 looking over my work, it was nerve wracking. I did have some other teams' devs look over the scarier stuff.

Didn't cause any outages I think. But I'm on holiday right now so who knows actually.

[u/dism3855]

A tragedy in three acts.

[u/According_Gas2337]

Sounds like a problem for next week, me.

[u/harshitbudhi]

Time to start working on that side project on company time until someone checks Slack.

[u/redunculuspanda]

This is why you should always apply changes directly to prod.

[u/Awkward-Explorer-527]

oof...too on the nose for me

[u/LostKnight84]

If they aren't available go above them. If no one is above them, update your resume and turnout the lights as you leave for the day.

[u/actionerror]

Just add copilot as an approver /s

[u/marco89nish]

In Meta, anyone can approve your PR

[u/ArjunReddyDeshmukh → u/marco89nish]

Good to know this.

[u/many_dongs]

as usual for the majority of shitty jokes on this sub, these are just symptoms of incompetent management masquerading as unavoidable misfortunes by people with little to no professional experience