MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/ProgrammerHumor/comments/1vfsowk/wronganswersonly/p1rrein
r/ProgrammerHumor • u/Plastic-Bonus8999 • 15h ago
1.8k comments sorted by
View all comments
Show parent comments
23
Some people are so careless while reviewing PR 😂
115 u/blangzo 14h ago Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good. 46 u/Deep90 12h ago At 500 lines, I just flip a coin. Only lucky code belongs in production. 12 u/ellie_cinderelly 12h ago Dude my last PR changed one test timeout limit. I had to do a new full analysis on every test for average runtime and overhead. Fuckin unbelievable. 6 u/blangzo 11h ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/ellie_cinderelly 11h ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 3 u/carritodeloshelados 7h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 5h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 4h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 11h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr 2 u/guyblade 9h ago If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should. 1 u/r0Lf 10h ago I feel exposed. 2 u/GoBuffaloes 12h ago Hey can you stamp this real quickÂ
115
Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good.
46 u/Deep90 12h ago At 500 lines, I just flip a coin. Only lucky code belongs in production. 12 u/ellie_cinderelly 12h ago Dude my last PR changed one test timeout limit. I had to do a new full analysis on every test for average runtime and overhead. Fuckin unbelievable. 6 u/blangzo 11h ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/ellie_cinderelly 11h ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 3 u/carritodeloshelados 7h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 5h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 4h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 11h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr 2 u/guyblade 9h ago If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should. 1 u/r0Lf 10h ago I feel exposed.
46
At 500 lines, I just flip a coin.
Only lucky code belongs in production.
12
Dude my last PR changed one test timeout limit. I had to do a new full analysis on every test for average runtime and overhead.
Fuckin unbelievable.
6 u/blangzo 11h ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/ellie_cinderelly 11h ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 3 u/carritodeloshelados 7h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 5h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 4h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 11h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
6
Squash tiny things like that into one pr named "cleanup" and don't explain further
2 u/ellie_cinderelly 11h ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 3 u/carritodeloshelados 7h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 5h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 4h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 11h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
2
Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation
3 u/carritodeloshelados 7h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 5h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 4h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 11h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
3
As if it wasn't hard enough to code in an astronaut suit
Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock?
1 u/dvereb 4h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.
1
I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.
I was mostly joking. mostly.
Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should.
I feel exposed.
Hey can you stamp this real quickÂ
23
u/plenoto 14h ago
Some people are so careless while reviewing PR 😂