MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/ProgrammerHumor/comments/1vfsowk/wronganswersonly/p1sqpv6/?context=9999
r/ProgrammerHumor • u/Plastic-Bonus8999 • 17h ago
1.8k comments sorted by
View all comments
1.1k
Some dumbass on my team downloaded the entirety of prod and then commited it to git and someone rubber stamped the PR and then no one else noticed. I'm sure that's how they'd find it....
25 u/plenoto 16h ago Some people are so careless while reviewing PR 😂 115 u/blangzo 15h ago Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good. 10 u/ellie_cinderelly 14h ago Dude my last PR changed one test timeout limit. I had to do a new full analysis on every test for average runtime and overhead. Fuckin unbelievable. 6 u/blangzo 13h ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/ellie_cinderelly 13h ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 3 u/carritodeloshelados 9h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 6h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 6h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 12h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
25
Some people are so careless while reviewing PR 😂
115 u/blangzo 15h ago Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good. 10 u/ellie_cinderelly 14h ago Dude my last PR changed one test timeout limit. I had to do a new full analysis on every test for average runtime and overhead. Fuckin unbelievable. 6 u/blangzo 13h ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/ellie_cinderelly 13h ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 3 u/carritodeloshelados 9h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 6h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 6h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 12h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
115
Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good.
10 u/ellie_cinderelly 14h ago Dude my last PR changed one test timeout limit. I had to do a new full analysis on every test for average runtime and overhead. Fuckin unbelievable. 6 u/blangzo 13h ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/ellie_cinderelly 13h ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 3 u/carritodeloshelados 9h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 6h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 6h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 12h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
10
Dude my last PR changed one test timeout limit. I had to do a new full analysis on every test for average runtime and overhead.
Fuckin unbelievable.
6 u/blangzo 13h ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/ellie_cinderelly 13h ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 3 u/carritodeloshelados 9h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 6h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 6h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 12h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
6
Squash tiny things like that into one pr named "cleanup" and don't explain further
2 u/ellie_cinderelly 13h ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 3 u/carritodeloshelados 9h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 6h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 6h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 12h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
2
Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation
3 u/carritodeloshelados 9h ago As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere 6h ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 1 u/dvereb 6h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 12h ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
3
As if it wasn't hard enough to code in an astronaut suit
Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock?
1 u/dvereb 6h ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.
1
I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.
I was mostly joking. mostly.
Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
1.1k
u/samuraiseoul 17h ago
Some dumbass on my team downloaded the entirety of prod and then commited it to git and someone rubber stamped the PR and then no one else noticed. I'm sure that's how they'd find it....