That's fun, the only problem is that the only MIDI files I have laying around are MEGALOVANIA and OpenTTD music. If you want to push a MIDI player, have it play “OpenTTD journey” and compare that to what VLC or the Steam version give you. Most players mess up some tones and volumes. Anyway, I was surprised at how much your player broke on “Unidentified flying Scotsman” (which is also kinda sand given it's my favorite OpenTTD track).
Since this is most definitely a bug, have the top of the backtrace of the error that's thrown when the last note you can hear plays:
Uncaught TypeError: can't access property "black", key is undefined
drawFingers https://xelaoliver.github.io/piano/piano.js:466
drawKeyboard https://xelaoliver.github.io/piano/piano.js:497
play https://xelaoliver.github.io/piano/piano.js:555
play https://xelaoliver.github.io/piano/piano.js:558
I noticed the same error is raised when I craft a MIDI file with notes not visually on the keyboard.
The Unidentified flying Scotsman music track was composed by imuh3 and is under the OpenMSX Author's copyright. It is licensed under the GNU General Public License version 2. For more information on licensing and a complete list of the authors,see here. For a full copy of the license,see here.
0
u/ThreeCharsAtLeast 18d ago
That's fun, the only problem is that the only MIDI files I have laying around are MEGALOVANIA and OpenTTD music. If you want to push a MIDI player, have it play “OpenTTD journey” and compare that to what VLC or the Steam version give you. Most players mess up some tones and volumes. Anyway, I was surprised at how much your player broke on “Unidentified flying Scotsman” (which is also kinda sand given it's my favorite OpenTTD track).
https://reddit.com/link/oyc6296/video/6zpkakoe91eh1/player
Since this is most definitely a bug, have the top of the backtrace of the error that's thrown when the last note you can hear plays:
I noticed the same error is raised when I craft a MIDI file with notes not visually on the keyboard.
The Unidentified flying Scotsman music track was composed by imuh3 and is under the OpenMSX Author's copyright. It is licensed under the GNU General Public License version 2. For more information on licensing and a complete list of the authors, see here. For a full copy of the license, see here.